Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/tools/check_grd_for_unused_strings.py

Issue 490813002: Fix the string resource paths in check_grd_unused_strings.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Without any args, this simply loads the IDs out of a bunch of the Chrome GRD 6 """Without any args, this simply loads the IDs out of a bunch of the Chrome GRD
7 files, and then checks the subset of the code that loads the strings to try 7 files, and then checks the subset of the code that loads the strings to try
8 and figure out what isn't in use any more. 8 and figure out what isn't in use any more.
9 You can give paths to GRD files and source directories to control what is 9 You can give paths to GRD files and source directories to control what is
10 check instead. 10 check instead.
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 grd_files.append(arg) 124 grd_files.append(arg)
125 else: 125 else:
126 src_dirs.append(arg) 126 src_dirs.append(arg)
127 127
128 # If no GRD files were given, default them: 128 # If no GRD files were given, default them:
129 if len(grd_files) == 0: 129 if len(grd_files) == 0:
130 ash_base_dir = os.path.join(src_dir, 'ash') 130 ash_base_dir = os.path.join(src_dir, 'ash')
131 chrome_app_dir = os.path.join(chrome_dir, 'app') 131 chrome_app_dir = os.path.join(chrome_dir, 'app')
132 chrome_app_res_dir = os.path.join(chrome_app_dir, 'resources') 132 chrome_app_res_dir = os.path.join(chrome_app_dir, 'resources')
133 device_base_dir = os.path.join(src_dir, 'device') 133 device_base_dir = os.path.join(src_dir, 'device')
134 ui_base_dir = os.path.join(src_dir, 'ui', 'base',) 134 ui_dir = os.path.join(src_dir, 'ui')
135 ui_base_strings_dir = os.path.join(ui_base_dir, 'strings') 135 ui_strings_dir = os.path.join(ui_dir, 'strings')
136 ui_chromeos_dir = os.path.join(ui_base_dir, 'chromeos', 'strings') 136 ui_chromeos_dir = os.path.join(ui_dir, 'chromeos')
137 grd_files = [ 137 grd_files = [
138 os.path.join(ash_base_dir, 'ash_strings.grd'), 138 os.path.join(ash_base_dir, 'ash_strings.grd'),
139 os.path.join(ash_base_dir, 'resources', 'ash_resources.grd'), 139 os.path.join(ash_base_dir, 'resources', 'ash_resources.grd'),
140 os.path.join(chrome_app_dir, 'chromium_strings.grd'), 140 os.path.join(chrome_app_dir, 'chromium_strings.grd'),
141 os.path.join(chrome_app_dir, 'generated_resources.grd'), 141 os.path.join(chrome_app_dir, 'generated_resources.grd'),
142 os.path.join(chrome_app_dir, 'google_chrome_strings.grd'), 142 os.path.join(chrome_app_dir, 'google_chrome_strings.grd'),
143 os.path.join(chrome_app_res_dir, 'locale_settings.grd'), 143 os.path.join(chrome_app_res_dir, 'locale_settings.grd'),
144 os.path.join(chrome_app_res_dir, 'locale_settings_chromiumos.grd'), 144 os.path.join(chrome_app_res_dir, 'locale_settings_chromiumos.grd'),
145 os.path.join(chrome_app_res_dir, 'locale_settings_google_chromeos.grd'), 145 os.path.join(chrome_app_res_dir, 'locale_settings_google_chromeos.grd'),
146 os.path.join(chrome_app_res_dir, 'locale_settings_linux.grd'), 146 os.path.join(chrome_app_res_dir, 'locale_settings_linux.grd'),
147 os.path.join(chrome_app_res_dir, 'locale_settings_mac.grd'), 147 os.path.join(chrome_app_res_dir, 'locale_settings_mac.grd'),
148 os.path.join(chrome_app_res_dir, 'locale_settings_win.grd'), 148 os.path.join(chrome_app_res_dir, 'locale_settings_win.grd'),
149 os.path.join(chrome_app_dir, 'theme', 'theme_resources.grd'), 149 os.path.join(chrome_app_dir, 'theme', 'theme_resources.grd'),
150 os.path.join(chrome_dir, 'browser', 'browser_resources.grd'), 150 os.path.join(chrome_dir, 'browser', 'browser_resources.grd'),
151 os.path.join(chrome_dir, 'common', 'common_resources.grd'), 151 os.path.join(chrome_dir, 'common', 'common_resources.grd'),
152 os.path.join(chrome_dir, 'renderer', 'resources', 152 os.path.join(chrome_dir, 'renderer', 'resources',
153 'renderer_resources.grd'), 153 'renderer_resources.grd'),
154 os.path.join(device_base_dir, 'bluetooth', 'bluetooth_strings.grd'), 154 os.path.join(device_base_dir, 'bluetooth', 'bluetooth_strings.grd'),
155 os.path.join(src_dir, 'extensions', 'extensions_strings.grd'), 155 os.path.join(src_dir, 'extensions', 'extensions_strings.grd'),
156 os.path.join(src_dir, 'ui', 'resources', 'ui_resources.grd'), 156 os.path.join(src_dir, 'ui', 'resources', 'ui_resources.grd'),
157 os.path.join(src_dir, 'ui', 'webui', 'resources', 'webui_resources.grd'), 157 os.path.join(src_dir, 'ui', 'webui', 'resources', 'webui_resources.grd'),
158 os.path.join(ui_base_strings_dir, 'app_locale_settings.grd'), 158 os.path.join(ui_strings_dir, 'app_locale_settings.grd'),
159 os.path.join(ui_base_strings_dir, 'ui_strings.grd'), 159 os.path.join(ui_strings_dir, 'ui_strings.grd'),
160 os.path.join(ui_chromeos_dir, 'ui_chromeos_strings.grd'), 160 os.path.join(ui_chromeos_dir, 'ui_chromeos_strings.grd'),
161 ] 161 ]
162 162
163 # If no source directories were given, default them: 163 # If no source directories were given, default them:
164 if len(src_dirs) == 0: 164 if len(src_dirs) == 0:
165 src_dirs = [ 165 src_dirs = [
166 os.path.join(src_dir, 'app'), 166 os.path.join(src_dir, 'app'),
167 os.path.join(src_dir, 'ash'), 167 os.path.join(src_dir, 'ash'),
168 os.path.join(src_dir, 'chrome'), 168 os.path.join(src_dir, 'chrome'),
169 os.path.join(src_dir, 'components'), 169 os.path.join(src_dir, 'components'),
170 os.path.join(src_dir, 'content'), 170 os.path.join(src_dir, 'content'),
171 os.path.join(src_dir, 'device'), 171 os.path.join(src_dir, 'device'),
172 os.path.join(src_dir, 'extensions'), 172 os.path.join(src_dir, 'extensions'),
173 os.path.join(src_dir, 'ui'), 173 os.path.join(src_dir, 'ui'),
174 # nsNSSCertHelper.cpp has a bunch of ids 174 # nsNSSCertHelper.cpp has a bunch of ids
175 os.path.join(src_dir, 'third_party', 'mozilla_security_manager'), 175 os.path.join(src_dir, 'third_party', 'mozilla_security_manager'),
176 os.path.join(chrome_dir, 'installer'), 176 os.path.join(chrome_dir, 'installer'),
177 ] 177 ]
178 178
179 return CheckForUnusedGrdIDsInSources(grd_files, src_dirs) 179 return CheckForUnusedGrdIDsInSources(grd_files, src_dirs)
180 180
181 181
182 if __name__ == '__main__': 182 if __name__ == '__main__':
183 sys.exit(main()) 183 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698