chrome/browser/guest_view/extension_options/extension_options_guest.cc - Issue 490783002: Handle closing web contents in ExtensionOptionsGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests for detecting onclose event in WebUI Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_guest.h ('k') | chrome/browser/resources/extensions/extension_options_overlay.html » ('j') | chrome/test/data/extensions/webui/receives_extension_options_on_close.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

index 43553ac2f5ee304f19f4b1217f377da35340a619..bb6da107cea95b768d7fa7098f085893a557500d 100644

--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

@@ -178,3 +178,9 @@ void ExtensionOptionsGuest::SetUpAutoSize() {

SetAutoSize(

true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));

}

+void ExtensionOptionsGuest::CloseContents(content::WebContents* source) {

+ DispatchEventToEmbedder(new extensions::GuestViewBase::Event(

+ extension_options_internal::OnClose::kEventName,

+ make_scoped_ptr(new base::DictionaryValue())));