chrome/browser/guest_view/extension_options/extension_options_guest.cc - Issue 490783002: Handle closing web contents in ExtensionOptionsGuest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests for detecting onclose event in WebUI Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_guest.h ('k') | chrome/browser/resources/extensions/extension_options_overlay.html » ('j') | chrome/test/data/extensions/webui/receives_extension_options_on_close.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"	5 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"

6	6

7 #include "base/values.h"	7 #include "base/values.h"

8 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"	8 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"

9 #include "chrome/browser/guest_view/extension_options/extension_options_constant s.h"	9 #include "chrome/browser/guest_view/extension_options/extension_options_constant s.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 160 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
171 int min_width = 0;	171 int min_width = 0;

172 extra_params()->GetInteger(extensionoptions::kAttributeMinHeight,	172 extra_params()->GetInteger(extensionoptions::kAttributeMinHeight,

173 &min_height);	173 &min_height);

174 extra_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);	174 extra_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);

175	175

176 // Call SetAutoSize to apply all the appropriate validation and clipping of	176 // Call SetAutoSize to apply all the appropriate validation and clipping of

177 // values.	177 // values.

178 SetAutoSize(	178 SetAutoSize(

179 true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));	179 true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));

180 }	180 }

	181

	182 void ExtensionOptionsGuest::CloseContents(content::WebContents* source) {

	183 DispatchEventToEmbedder(new extensions::GuestViewBase::Event(

	184 extension_options_internal::OnClose::kEventName,

	185 make_scoped_ptr(new base::DictionaryValue())));

	186 }

OLD	NEW