Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.js

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_options_overlay.js
diff --git a/chrome/browser/resources/extensions/extension_options_overlay.js b/chrome/browser/resources/extensions/extension_options_overlay.js
index 899098d625ec446767be32d832602b97367fd582..29597ac0c3b45e8c5a99fa684cd444b4963bde0a 100644
--- a/chrome/browser/resources/extensions/extension_options_overlay.js
+++ b/chrome/browser/resources/extensions/extension_options_overlay.js
@@ -64,6 +64,10 @@ cr.define('extensions', function() {
extensionoptions.extension = extensionId;
extensionoptions.autosize = 'on';
+ extensionoptions.onclose = function() {
+ this.handleDismiss_();
Fady Samuel 2014/08/20 14:53:55 The intent here is to remove the extensionoptions
ericzeng 2014/08/20 17:26:00 The higher level intent is to close the entire ove
+ }.bind(this);
+
// TODO(ericzeng): Resize in a non-jarring way.
extensionoptions.onsizechanged = function(evt) {
$('extension-options-overlay').style.width = evt.width;

Powered by Google App Engine
This is Rietveld 408576698