Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1645)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 490783002: Handle closing web contents in ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
index f7ca2908f72de01663b09ff9edfdecbc4ea2d6c1..d3fba0fdfce52c4cfdb83cfeaec6987ede547be3 100644
--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
@@ -177,3 +177,9 @@ void ExtensionOptionsGuest::SetUpAutoSize() {
SetAutoSize(
true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));
}
+
+void ExtensionOptionsGuest::CloseContents(content::WebContents* source) {
+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+ DispatchEventToEmbedder(new extensions::GuestViewBase::Event(
+ extension_options_internal::OnClose::kEventName, args.Pass()));
not at google - send to devlin 2014/08/20 02:16:37 Inline |args|? You can do make_scoped_ptr(new bas
ericzeng 2014/08/20 17:26:00 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698