Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 490763003: Delete PrintingUIWebContentsObserver on UI thread. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Delete PrintingUIWebContentsObserver on UI thread. BUG=374321 TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/printing/print_job_worker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/printing/printing_ui_web_contents_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/printing_ui_web_contents_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-20 02:40:58 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 02:41:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/490763003/1
6 years, 4 months ago (2014-08-20 02:42:11 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 04:05:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 05:18:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/3512)
6 years, 4 months ago (2014-08-20 05:18:09 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 05:37:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/490763003/1
6 years, 4 months ago (2014-08-20 05:38:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 06:28:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 290785
6 years, 4 months ago (2014-08-20 07:33:53 UTC) #10
Noam Samuel
6 years, 4 months ago (2014-08-20 18:06:11 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698