chrome/browser/printing/print_job_worker.cc - Issue 490763003: Delete PrintingUIWebContentsObserver on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 490763003: Delete PrintingUIWebContentsObserver on UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_job_worker.cc

diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc

index dd9c84b101ee8be6953bf708d073c0ea539e0b0e..85d178bfbf20651d4201df85f8823d00d5836df3 100644

--- a/chrome/browser/printing/print_job_worker.cc

+++ b/chrome/browser/printing/print_job_worker.cc

@@ -105,6 +105,8 @@ void PrintJobWorker::GetSettings(

document_page_count,

has_selection)));

} else {

+ BrowserThread::DeleteSoon(

+ BrowserThread::UI, FROM_HERE, web_contents_observer.release());

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(&HoldRefCallback, make_scoped_refptr(owner_),

« no previous file with comments | « no previous file | chrome/browser/printing/printing_ui_web_contents_observer.h » ('j') | no next file with comments »