Remove dependency of common on variations browser code

components/variations.gypi

Index: components/variations.gypi
diff --git a/components/variations.gypi b/components/variations.gypi
index c3589aea4ba12150939c4324d7cb59f6bbdf4d33..edde2571ac8a36a04a7ec6125a9579dfd83f0c28 100644
--- a/components/variations.gypi
+++ b/components/variations.gypi
@@ -12,9 +12,10 @@
         '..',
       ],
       'dependencies': [
+        # List of dependencies is intentionally very minimal. Please avoid
+        # adding extra dependencies without first checking with OWNERS.
         '../base/base.gyp:base',
         '../third_party/mt19937ar/mt19937ar.gyp:mt19937ar',
-        'components.gyp:google_core_browser',
       ],
       'sources': [
         'variations/active_field_trials.cc',
@@ -41,8 +42,6 @@
         'variations/study_filtering.h',
         'variations/variations_associated_data.cc',
         'variations/variations_associated_data.h',
-        'variations/variations_http_header_provider.cc',
-        'variations/variations_http_header_provider.h',
         'variations/variations_seed_processor.cc',
         'variations/variations_seed_processor.h',
         'variations/variations_seed_simulator.cc',
@@ -61,6 +60,23 @@
         }],
       ],
     },
+    {
+      # GN version: //components/variations_http_provider
+      'target_name': 'variations_http_provider',

[blundell, 2014/08/25 08:21:53]

This is code that should be depended on only from the browser, whereas the
variations target above can be depended on from browser and renderer code, is
that correct? If so, the best way to indicate that would be to move the
variations component into a structure where it had common/ and browser/
subdirectories and do the following target renames (and corresponding file
moves):
variations -> variations_common
variations_http_provider -> variations_browser

+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+      ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        'components.gyp:google_core_browser',
+        'variations',
+      ],
+      'sources': [
+        'variations/variations_http_header_provider.cc',
+        'variations/variations_http_header_provider.h',
+      ],
+    },
   ],
   'conditions': [
     ['OS=="android"', {