Remove dependency of common on variations browser code

components/variations.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //components/variations
       'target_name': 'variations',
       'type': 'static_library',
       'include_dirs': [
         '..',
       ],
       'dependencies': [
+        # List of dependencies is intentionally very minimal. Please avoid
+        # adding extra dependencies without first checking with OWNERS.
         '../base/base.gyp:base',
         '../third_party/mt19937ar/mt19937ar.gyp:mt19937ar',
-        'components.gyp:google_core_browser',
       ],
       'sources': [
         'variations/active_field_trials.cc',
         'variations/active_field_trials.h',
         'variations/android/component_jni_registrar.cc',
         'variations/android/component_jni_registrar.h',
         'variations/android/variations_associated_data_android.cc',
         'variations/android/variations_associated_data_android.h',
         'variations/caching_permuted_entropy_provider.cc',
         'variations/caching_permuted_entropy_provider.h',
         'variations/entropy_provider.cc',
         'variations/entropy_provider.h',
         'variations/metrics_util.cc',
         'variations/metrics_util.h',
         'variations/pref_names.cc',
         'variations/pref_names.h',
         'variations/processed_study.cc',
         'variations/processed_study.h',
         'variations/proto/client_variations.proto',
         'variations/proto/permuted_entropy_cache.proto',
         'variations/proto/study.proto',
         'variations/proto/variations_seed.proto',
         'variations/study_filtering.cc',
         'variations/study_filtering.h',
         'variations/variations_associated_data.cc',
         'variations/variations_associated_data.h',
-        'variations/variations_http_header_provider.cc',
-        'variations/variations_http_header_provider.h',
         'variations/variations_seed_processor.cc',
         'variations/variations_seed_processor.h',
         'variations/variations_seed_simulator.cc',
         'variations/variations_seed_simulator.h',
       ],
       'variables': {
         'proto_in_dir': 'variations/proto',
         'proto_out_dir': 'components/variations/proto',
       },
       'includes': [ '../build/protoc.gypi' ],
       'conditions': [
         ['OS == "android"', {
           'dependencies': [
             'variations_jni_headers',
           ],
         }],
       ],
     },
+    {
+      # GN version: //components/variations_http_provider
+      'target_name': 'variations_http_provider',

[blundell, 2014/08/25 08:21:53]

This is code that should be depended on only from the browser, whereas the
variations target above can be depended on from browser and renderer code, is
that correct? If so, the best way to indicate that would be to move the
variations component into a structure where it had common/ and browser/
subdirectories and do the following target renames (and corresponding file
moves):
variations -> variations_common
variations_http_provider -> variations_browser

+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+      ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        'components.gyp:google_core_browser',
+        'variations',
+      ],
+      'sources': [
+        'variations/variations_http_header_provider.cc',
+        'variations/variations_http_header_provider.h',
+      ],
+    },
   ],
   'conditions': [
     ['OS=="android"', {
       'targets': [
         {
           'target_name': 'variations_java',
           'type': 'none',
           'dependencies': [
             '../base/base.gyp:base',
           ],
@@ skipping 10 matching lines @@
           ],
           'variables': {
             'jni_gen_package': 'variations',
           },
           'includes': [ '../build/jni_generator.gypi' ],
         },
       ],
     }],
   ]
 }