Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 490203002: Supervised user "learn more" page: Fix css flex usage. (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Supervised user "learn more" page: Fix css flex usage. Was broken in r286486 / https://codereview.chromium.org/403343002. NOTRY=true BUG=405899 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/options/supervised_user_learn_more.css View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Marc Treib
Turns out the new css flex standard is quite different to -webkit-box-flex (which some presubmit ...
6 years, 4 months ago (2014-08-21 13:17:02 UTC) #1
Pam (message me for reviews)
lgtm
6 years, 4 months ago (2014-08-21 14:24:58 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-21 14:25:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/490203002/1
6 years, 4 months ago (2014-08-21 14:26:57 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 15:09:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291073

Powered by Google App Engine
This is Rietveld 408576698