Source/web/WebLocalFrameImpl.h - Issue 490143002: Move GeolocationClient to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebLocalFrameImpl.h

diff --git a/Source/web/WebLocalFrameImpl.h b/Source/web/WebLocalFrameImpl.h

index 0befafeeec326c9bb5d49745c382460e9c13a170..5a695ad4a7536ea72055023155fb6546a1496ddf 100644

--- a/Source/web/WebLocalFrameImpl.h

+++ b/Source/web/WebLocalFrameImpl.h

@@ -354,7 +354,7 @@ private:

UserMediaClientImpl m_userMediaClientImpl;

- OwnPtr<GeolocationClientProxy> m_geolocationClientProxy;

+ OwnPtrWillBePersistent<GeolocationClientProxy> m_geolocationClientProxy;

};

DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());