Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index b29dbe64f152eed6977f8b870b52a81721fceff3..d289ffd3a93098c8308e4ad99fc9123a09762702 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -497,14 +497,6 @@ void WebLocalFrameImpl::close()
{
m_client = 0;
- // FIXME: Oilpan: Signal to LocalFrame and its supplements that the frame is
- // being torn down so it can do prompt clean-up. For example, this will
- // clear the raw back pointer to m_geolocationClientProxy. Once
- // GeolocationClientProxy is on-heap it looks like we can completely remove
- // |willBeDestroyed| from supplements since tracing will ensure safety.
- if (m_frame)
- m_frame->willBeDestroyed();
-
deref(); // Balances ref() acquired in WebFrame::create
}
@@ -1529,7 +1521,7 @@ WebLocalFrameImpl::WebLocalFrameImpl(WebFrameClient* client)
, m_permissionClient(0)
, m_inputEventsScaleFactorForEmulation(1)
, m_userMediaClientImpl(this)
- , m_geolocationClientProxy(adoptPtr(new GeolocationClientProxy(client ? client->geolocationClient() : 0)))
+ , m_geolocationClientProxy(GeolocationClientProxy::create(client ? client->geolocationClient() : 0))
{
Platform::current()->incrementStatsCounter(webFrameActiveCount);
frameCount++;

Powered by Google App Engine
This is Rietveld 408576698