Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1976)

Unified Diff: Source/web/GeolocationClientProxy.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/GeolocationClientProxy.h
diff --git a/Source/web/GeolocationClientProxy.h b/Source/web/GeolocationClientProxy.h
index c7418690e3d6c14ae6fd6de7c0f1cc46200478e5..e6e9b9dca5ca88280a73f871a0725d9faeaf388b 100644
--- a/Source/web/GeolocationClientProxy.h
+++ b/Source/web/GeolocationClientProxy.h
@@ -37,10 +37,13 @@ class WebGeolocationClient;
class GeolocationClientProxy FINAL : public GeolocationClient {
public:
- GeolocationClientProxy(WebGeolocationClient* client);
+ static PassOwnPtrWillBeRawPtr<GeolocationClientProxy> create(WebGeolocationClient* client)
+ {
+ return adoptPtrWillBeNoop(new GeolocationClientProxy(client));
+ }
+
virtual ~GeolocationClientProxy();
void setController(GeolocationController*);
- virtual void geolocationDestroyed() OVERRIDE;
virtual void startUpdating() OVERRIDE;
virtual void stopUpdating() OVERRIDE;
virtual void setEnableHighAccuracy(bool) OVERRIDE;
@@ -49,9 +52,13 @@ public:
virtual void requestPermission(Geolocation*) OVERRIDE;
virtual void cancelPermissionRequest(Geolocation*) OVERRIDE;
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
+ explicit GeolocationClientProxy(WebGeolocationClient*);
+
WebGeolocationClient* m_client;
- Persistent<GeolocationPosition> m_lastPosition;
+ PersistentWillBeMember<GeolocationPosition> m_lastPosition;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698