Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: Source/platform/Supplementable.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Provide default empty impl of WebGeolocationClient::geolocationDestroyed() virtual Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/Supplementable.h
diff --git a/Source/platform/Supplementable.h b/Source/platform/Supplementable.h
index 47cbf407b3f4663e3183d5ee7649a60664d4448f..c5e5b0719b767e488d124470895cccbaa19d3bbf 100644
--- a/Source/platform/Supplementable.h
+++ b/Source/platform/Supplementable.h
@@ -144,8 +144,6 @@ public:
return host ? host->requireSupplement(key) : 0;
}
- virtual void willBeDestroyed() { }
-
// FIXME: Oilpan: Remove this callback once PersistentHeapSupplementable is removed again.
virtual void persistentHostHasBeenDestroyed() { }
};
@@ -187,13 +185,6 @@ public:
// since we only want to trace it for garbage collected classes.
virtual void trace(Visitor*) { }
- void willBeDestroyed()
- {
- typedef typename SupplementableTraits<T, isGarbageCollected>::SupplementMap::iterator SupplementIterator;
- for (SupplementIterator it = m_supplements.begin(); it != m_supplements.end(); ++it)
- it->value->willBeDestroyed();
- }
-
// FIXME: Oilpan: Make private and remove this ignore once PersistentHeapSupplementable is removed again.
protected:
GC_PLUGIN_IGNORE("")

Powered by Google App Engine
This is Rietveld 408576698