Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489763002: MacViews: Gets a webview working in views_examples_with_content_exe

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Gets a webview working in views_examples_with_content_exe BUG=399191

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : This is how WebContentsViewDelegate will look now #

Patch Set 4 : sneak peek - webview working \o/ #

Patch Set 5 : better #

Patch Set 6 : tests working on MacViews #

Patch Set 7 : less churn - ditch the pure virtual #

Patch Set 8 : fix android #

Patch Set 9 : fix test on win, fix android #

Patch Set 10 : rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -175 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_web_contents_view_delegate.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M athena/content/web_contents_view_delegate_factory_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M athena/main/athena_main.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h View 1 2 5 6 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 1 2 3 4 5 6 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/chrome_web_contents_view_delegate.h View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/confirm_bubble_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 2 3 4 5 9 chunks +25 lines, -9 lines 0 comments Download
A chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_mac.mm View 1 2 3 4 5 6 1 chunk +82 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_unittest.cc View 1 2 3 4 1 chunk +4 lines, -10 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 2 chunks +30 lines, -1 line 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 3 4 5 6 7 8 9 6 chunks +20 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 1 2 3 4 5 6 2 chunks +18 lines, -35 lines 0 comments Download
A content/public/browser/web_contents_view_delegate.cc View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
A content/public/browser/web_contents_view_delegate_mac.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate.h View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_android.cc View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_mac.mm View 1 2 3 4 5 6 2 chunks +1 line, -11 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -20 lines 0 comments Download
M ui/message_center/views/message_popup_collection_unittest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
A ui/views/controls/native/native_view_host_mac.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
D ui/views/controls/native/native_view_host_mac.cc View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
A ui/views/controls/native/native_view_host_mac.mm View 1 2 3 4 5 1 chunk +103 lines, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_unittest.cc View 1 2 3 4 5 6 7 8 7 chunks +75 lines, -15 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 2 3 4 5 1 chunk +28 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_client_main_parts_mac.mm View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tapted
Patchset #4 (id:120001) has been deleted
6 years, 3 months ago (2014-08-26 08:29:49 UTC) #1
tapted
Patchset #4 (id:140001) has been deleted
6 years, 3 months ago (2014-08-27 04:57:20 UTC) #2
tapted
Patchset #5 (id:180001) has been deleted
6 years, 3 months ago (2014-08-27 05:05:51 UTC) #3
tapted
Patchset #5 (id:200001) has been deleted
6 years, 3 months ago (2014-08-27 08:54:15 UTC) #4
tapted
Patchset #8 (id:280001) has been deleted
6 years, 3 months ago (2014-08-27 08:54:33 UTC) #5
tapted
Patchset #7 (id:260001) has been deleted
6 years, 3 months ago (2014-08-27 08:54:44 UTC) #6
tapted
6 years, 3 months ago (2014-08-27 13:58:06 UTC) #7 
Patchset #10 (id:360001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698