Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5500)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 489753002: Added proper extension manifest parser for launcher_page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Blank line. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
index 085c1a872c98cccac573c04116f91f2667794b11..81fc7c1e0cafb5e86ceaa505ba4b0d38ce5bcd4d 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/command_line.h"
#include "base/i18n/rtl.h"
#include "base/path_service.h"
#include "base/strings/utf_string_conversions.h"
@@ -11,11 +12,19 @@
#include "components/crx_file/id_util.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest_constants.h"
+#include "extensions/common/switches.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
namespace extensions {
+namespace {
+
+// The ID of test manifests requiring whitelisting.
+const char kWhitelistID[] = "lmadimbbgapmngbiclpjjngmdickadpl";
+
+} // namespace
+
namespace errors = manifest_errors;
namespace keys = manifest_keys;
@@ -23,6 +32,8 @@ class InitValueManifestTest : public ExtensionManifestTest {
};
TEST_F(InitValueManifestTest, InitFromValueInvalid) {
+ CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ extensions::switches::kWhitelistedExtensionID, kWhitelistID);
Testcase testcases[] = {
Testcase("init_invalid_version_missing.json", errors::kInvalidVersion),
Testcase("init_invalid_version_invalid.json", errors::kInvalidVersion),
@@ -32,6 +43,12 @@ TEST_F(InitValueManifestTest, InitFromValueInvalid) {
errors::kInvalidDescription),
Testcase("init_invalid_icons_invalid.json", errors::kInvalidIcons),
Testcase("init_invalid_icons_path_invalid.json", errors::kInvalidIconPath),
+ Testcase("init_invalid_launcher_page_invalid.json",
+ errors::kInvalidLauncherPage),
+ Testcase("init_invalid_launcher_page_page_missing.json",
+ errors::kLauncherPagePageRequired),
+ Testcase("init_invalid_launcher_page_page_invalid.json",
+ errors::kInvalidLauncherPagePage),
Testcase("init_invalid_script_invalid.json",
errors::kInvalidContentScriptsList),
Testcase("init_invalid_script_item_invalid.json",
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/manifest_tests/extension_manifests_launcher_page_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698