Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 489753002: Added proper extension manifest parser for launcher_page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Blank line. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h"
5 #include "base/i18n/rtl.h" 6 #include "base/i18n/rtl.h"
6 #include "base/path_service.h" 7 #include "base/path_service.h"
7 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/common/chrome_paths.h" 9 #include "chrome/common/chrome_paths.h"
9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
10 #include "chrome/common/extensions/manifest_url_handler.h" 11 #include "chrome/common/extensions/manifest_url_handler.h"
11 #include "components/crx_file/id_util.h" 12 #include "components/crx_file/id_util.h"
12 #include "extensions/common/extension.h" 13 #include "extensions/common/extension.h"
13 #include "extensions/common/manifest_constants.h" 14 #include "extensions/common/manifest_constants.h"
15 #include "extensions/common/switches.h"
14 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
15 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
16 18
17 namespace extensions { 19 namespace extensions {
18 20
21 namespace {
22
23 // The ID of test manifests requiring whitelisting.
24 const char kWhitelistID[] = "lmadimbbgapmngbiclpjjngmdickadpl";
25
26 } // namespace
27
19 namespace errors = manifest_errors; 28 namespace errors = manifest_errors;
20 namespace keys = manifest_keys; 29 namespace keys = manifest_keys;
21 30
22 class InitValueManifestTest : public ExtensionManifestTest { 31 class InitValueManifestTest : public ExtensionManifestTest {
23 }; 32 };
24 33
25 TEST_F(InitValueManifestTest, InitFromValueInvalid) { 34 TEST_F(InitValueManifestTest, InitFromValueInvalid) {
35 CommandLine::ForCurrentProcess()->AppendSwitchASCII(
36 extensions::switches::kWhitelistedExtensionID, kWhitelistID);
26 Testcase testcases[] = { 37 Testcase testcases[] = {
27 Testcase("init_invalid_version_missing.json", errors::kInvalidVersion), 38 Testcase("init_invalid_version_missing.json", errors::kInvalidVersion),
28 Testcase("init_invalid_version_invalid.json", errors::kInvalidVersion), 39 Testcase("init_invalid_version_invalid.json", errors::kInvalidVersion),
29 Testcase("init_invalid_name_missing.json", errors::kInvalidName), 40 Testcase("init_invalid_name_missing.json", errors::kInvalidName),
30 Testcase("init_invalid_name_invalid.json", errors::kInvalidName), 41 Testcase("init_invalid_name_invalid.json", errors::kInvalidName),
31 Testcase("init_invalid_description_invalid.json", 42 Testcase("init_invalid_description_invalid.json",
32 errors::kInvalidDescription), 43 errors::kInvalidDescription),
33 Testcase("init_invalid_icons_invalid.json", errors::kInvalidIcons), 44 Testcase("init_invalid_icons_invalid.json", errors::kInvalidIcons),
34 Testcase("init_invalid_icons_path_invalid.json", errors::kInvalidIconPath), 45 Testcase("init_invalid_icons_path_invalid.json", errors::kInvalidIconPath),
46 Testcase("init_invalid_launcher_page_invalid.json",
47 errors::kInvalidLauncherPage),
48 Testcase("init_invalid_launcher_page_page_missing.json",
49 errors::kLauncherPagePageRequired),
50 Testcase("init_invalid_launcher_page_page_invalid.json",
51 errors::kInvalidLauncherPagePage),
35 Testcase("init_invalid_script_invalid.json", 52 Testcase("init_invalid_script_invalid.json",
36 errors::kInvalidContentScriptsList), 53 errors::kInvalidContentScriptsList),
37 Testcase("init_invalid_script_item_invalid.json", 54 Testcase("init_invalid_script_item_invalid.json",
38 errors::kInvalidContentScript), 55 errors::kInvalidContentScript),
39 Testcase("init_invalid_script_matches_missing.json", 56 Testcase("init_invalid_script_matches_missing.json",
40 errors::kInvalidMatches), 57 errors::kInvalidMatches),
41 Testcase("init_invalid_script_matches_invalid.json", 58 Testcase("init_invalid_script_matches_invalid.json",
42 errors::kInvalidMatches), 59 errors::kInvalidMatches),
43 Testcase("init_invalid_script_matches_empty.json", 60 Testcase("init_invalid_script_matches_empty.json",
44 errors::kInvalidMatchCount), 61 errors::kInvalidMatchCount),
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 171
155 localized_name = base::WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)"); 172 localized_name = base::WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)");
156 base::i18n::AdjustStringForLocaleDirection(&localized_name); 173 base::i18n::AdjustStringForLocaleDirection(&localized_name);
157 EXPECT_EQ(localized_name, base::UTF8ToUTF16(extension->name())); 174 EXPECT_EQ(localized_name, base::UTF8ToUTF16(extension->name()));
158 175
159 // Reset locale. 176 // Reset locale.
160 base::i18n::SetICUDefaultLocale(locale); 177 base::i18n::SetICUDefaultLocale(locale);
161 } 178 }
162 179
163 } // namespace extensions 180 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/manifest_tests/extension_manifests_launcher_page_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698