Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489703003: get_appengine.py: fix for go_appengine (Closed)

Created:
6 years, 4 months ago by ukai
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

get_appengine.py: fix for go_appengine we should preserve timestamp of files in go_appengine SDK. otherwise, goapp test won't work. BUG=405946 Committed: https://chromium.googlesource.com/infra/infra/+/0ccaafda7bc9529bc911162451e41def085beb18

Patch Set 1 #

Total comments: 2

Patch Set 2 : move os.utimes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M bootstrap/get_appengine.py View 1 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ukai
6 years, 4 months ago (2014-08-21 07:46:45 UTC) #1
Paweł Hajdan Jr.
https://codereview.chromium.org/489703003/diff/1/bootstrap/get_appengine.py File bootstrap/get_appengine.py (right): https://codereview.chromium.org/489703003/diff/1/bootstrap/get_appengine.py#newcode58 bootstrap/get_appengine.py:58: os.utime(filepath, (mtime, mtime)) Since this is the same for ...
6 years, 4 months ago (2014-08-21 10:23:05 UTC) #2
ukai
https://codereview.chromium.org/489703003/diff/1/bootstrap/get_appengine.py File bootstrap/get_appengine.py (right): https://codereview.chromium.org/489703003/diff/1/bootstrap/get_appengine.py#newcode58 bootstrap/get_appengine.py:58: os.utime(filepath, (mtime, mtime)) On 2014/08/21 10:23:05, Paweł Hajdan Jr. ...
6 years, 4 months ago (2014-08-21 14:12:18 UTC) #3
ukai
6 years, 4 months ago (2014-08-21 14:12:19 UTC) #4
ukai
ping
6 years, 4 months ago (2014-08-22 01:22:36 UTC) #5
Paweł Hajdan Jr.
LGTM
6 years, 4 months ago (2014-08-22 11:32:46 UTC) #6
ukai
The CQ bit was checked by ukai@chromium.org
6 years, 3 months ago (2014-08-27 06:03:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ukai@chromium.org/489703003/20001
6 years, 3 months ago (2014-08-27 06:03:17 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 06:03:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 0ccaafda7bc9529bc911162451e41def085beb18

Powered by Google App Engine
This is Rietveld 408576698