get_appengine.py: fix for go_appengine

bootstrap/get_appengine.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import datetime
 import logging
 import optparse
 import os
 import re
 import shutil
 import sys
+import time
 import tempfile
 import urllib2
 import zipfile
 
 BASE_DIR = os.path.dirname(os.path.abspath(__file__))
 
 
 def get_gae_sdk_version(gae_path):
   """Returns the installed GAE SDK version or None."""
   version_path = os.path.join(gae_path, 'VERSION')
@@ skipping 19 matching lines @@
   new_version = re.search(re.escape(name) + r'(.+?).zip', url).group(1)
   # Upgrade to https
   return url.replace('http://', 'https://'), new_version
 
 
 def extract_zip(z, root_path):
   """Extracts files in a zipfile but keep the executable bits."""
   count = 0
   for f in z.infolist():
     perm = (f.external_attr >> 16L) & 0777
+    mtime = time.mktime(datetime.datetime(*f.date_time).timetuple())
     filepath = os.path.join(root_path, f.filename)
     logging.debug('Extracting %s', f.filename)
     if f.filename.endswith('/'):
       os.mkdir(filepath, perm)
+      os.utime(filepath, (mtime, mtime))

[Paweł Hajdan Jr., 2014/08/21 10:23:05]

Since this is the same for both branches, why not extract it out of the "if"?

[ukai, 2014/08/21 14:12:18]

Done.

     else:
       z.extract(f, root_path)
       os.chmod(filepath, perm)
+      os.utime(filepath, (mtime, mtime))
       count += 1
   print('Extracted %d files' % count)
 
 
 def install_latest_gae_sdk(root_path, fetch_go, dry_run):
   if fetch_go:
     rootdir = 'go_appengine'
     if sys.platform == 'darwin':
       name = 'go_appengine_sdk_darwin_amd64-'
     else:
@@ skipping 54 matching lines @@
   options, args = parser.parse_args()
   if args:
     parser.error('Unsupported args: %s' % ' '.join(args))
   logging.basicConfig(level=logging.DEBUG if options.verbose else logging.ERROR)
   return install_latest_gae_sdk(
       os.path.abspath(options.dest), options.go, options.dry_run)
 
 
 if __name__ == '__main__':
   sys.exit(main())