Issue 489603002: Replace ONC crash on Release with ERROR, crash on Debug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 489603002: Replace ONC crash on Release with ERROR, crash on Debug (Closed)

Created:
6 years, 4 months ago by stevenjb

Modified:
6 years, 4 months ago

Reviewers:
pneubeck (no reviews)

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace ONC crash on Release with ERROR, crash on Debug BUG=404708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290798

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chromeos/network/onc/onc_translator_shill_to_onc.cc	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

lgtm https://codereview.chromium.org/489603002/diff/1/chromeos/network/onc/onc_translator_shill_to_onc.cc File chromeos/network/onc/onc_translator_shill_to_onc.cc (right): https://codereview.chromium.org/489603002/diff/1/chromeos/network/onc/onc_translator_shill_to_onc.cc#newcode402 chromeos/network/onc/onc_translator_shill_to_onc.cc:402: NOTREACHED() << "Unable to find signature for field: ...

6 years, 4 months ago (2014-08-20 08:49:28 UTC) #2

pneubeck (no reviews)

The CQ bit was checked by pneubeck@chromium.org

6 years, 4 months ago (2014-08-20 08:49:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/489603002/1

6 years, 4 months ago (2014-08-20 08:50:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290798

Expand Messages | Collapse Messages