Replace ONC crash on Release with ERROR, crash on Debug

chromeos/network/onc/onc_translator_shill_to_onc.cc

Index: chromeos/network/onc/onc_translator_shill_to_onc.cc
diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc
index dc01b2a53dd51335958cc529ae46db46780fe5c8..19e7eff0b853eafc35ca31e6530a9863b60a5dad 100644
--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc
+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc
@@ -398,8 +398,10 @@ void ShillToONCTranslator::TranslateAndAddNestedObject(
     const base::DictionaryValue& dictionary) {
   const OncFieldSignature* field_signature =
       GetFieldSignature(*onc_signature_, onc_field_name);
-  DCHECK(field_signature) << "Unable to find signature for field "
-                          << onc_field_name << ".";
+  if (!field_signature) {
+    NOTREACHED() << "Unable to find signature for field: " << onc_field_name;

[pneubeck (no reviews), 2014/08/20 08:49:28]

This case indicates without doubt that we have an implementation error in Chrome
or an inconsistency with Shill.
We should really try to fix the cause for this.

+    return;
+  }
   ShillToONCTranslator nested_translator(dictionary,
                                          *field_signature->value_signature);
   scoped_ptr<base::DictionaryValue> nested_object =