Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 489423002: Fix build.dart: sourceUrl used to be a String before the change to source_span (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix build.dart: sourceUrl used to be a Strnig before the change to source_span R=jakemac@google.com Committed: https://code.google.com/p/dart/source/detail?r=39458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/polymer/lib/src/build/runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-21 16:09:38 UTC) #1
Siggi Cherem (dart-lang)
(this is to fix: https://code.google.com/p/dart/issues/detail?id=20621)
6 years, 4 months ago (2014-08-21 16:09:58 UTC) #2
jakemac
lgtm
6 years, 4 months ago (2014-08-21 16:17:23 UTC) #3
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-08-21 16:57:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39458 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698