pkg/polymer/lib/src/build/runner.dart - Issue 489423002: Fix build.dart: sourceUrl used to be a String before the change to source_span

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/lib/src/build/runner.dart

Issue 489423002: Fix build.dart: sourceUrl used to be a String before the change to source_span (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer/lib/src/build/runner.dart

diff --git a/pkg/polymer/lib/src/build/runner.dart b/pkg/polymer/lib/src/build/runner.dart

index 2a9e18a464c0f5461d11fd1dd3c4d455deea0032..dff520bb876e814a5923b468024eaed824fbb0f0 100644

--- a/pkg/polymer/lib/src/build/runner.dart

+++ b/pkg/polymer/lib/src/build/runner.dart

@@ -346,7 +346,7 @@ String _jsonFormatter(LogEntry entry) {

? [{'method': kind, 'params': {'message': entry.message}}]

: [{'method': kind,

'params': {

- 'file': span.sourceUrl,

+ 'file': span.sourceUrl.toString(),

'message': entry.message,

'line': span.start.line + 1,

'charStart': span.start.offset,

« no previous file with comments | « no previous file | no next file » | no next file with comments »