platform_tools/android/gyp_gen/makefile_writer.py - Issue 489373004: Cleanup FDO options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 489373004: Cleanup FDO options. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/gyp_gen/makefile_writer.py

diff --git a/platform_tools/android/gyp_gen/makefile_writer.py b/platform_tools/android/gyp_gen/makefile_writer.py

index 55a71d00ca00b14ae4e9e078a1f197e36afea9f0..dbefa5ee838b2cd297b54a7616ec4a77e1680c97 100644

--- a/platform_tools/android/gyp_gen/makefile_writer.py

+++ b/platform_tools/android/gyp_gen/makefile_writer.py

@@ -198,8 +198,7 @@ def write_android_mk(target_dir, common, deviations_from_common):

# need flags to enable feedback driven optimization (FDO) when requested

# by the build system.

f.write('LOCAL_FDO_SUPPORT := true\n')

- f.write(

- 'ifneq ($(strip $($(LOCAL_2ND_ARCH_VAR_PREFIX)TARGET_FDO_CFLAGS)),)\n')

+ f.write('ifneq ($(strip $(TARGET_FDO_CFLAGS)),)\n')

f.write('\t# This should be the last -Oxxx specified in LOCAL_CFLAGS\n')

f.write('\tLOCAL_CFLAGS += -O2\n')

f.write('endif\n\n')

« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »