Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 489373004: Cleanup FDO options. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright 2014 Google Inc. 3 # Copyright 2014 Google Inc.
4 # 4 #
5 # Use of this source code is governed by a BSD-style license that can be 5 # Use of this source code is governed by a BSD-style license that can be
6 # found in the LICENSE file. 6 # found in the LICENSE file.
7 7
8 """ 8 """
9 Functions for creating an Android.mk from already created dictionaries. 9 Functions for creating an Android.mk from already created dictionaries.
10 """ 10 """
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 f.write('BASE_PATH := $(call my-dir)\n') 191 f.write('BASE_PATH := $(call my-dir)\n')
192 write_local_path(f) 192 write_local_path(f)
193 193
194 f.write(DEBUGGING_HELP) 194 f.write(DEBUGGING_HELP)
195 195
196 write_clear_vars(f) 196 write_clear_vars(f)
197 197
198 # need flags to enable feedback driven optimization (FDO) when requested 198 # need flags to enable feedback driven optimization (FDO) when requested
199 # by the build system. 199 # by the build system.
200 f.write('LOCAL_FDO_SUPPORT := true\n') 200 f.write('LOCAL_FDO_SUPPORT := true\n')
201 f.write( 201 f.write('ifneq ($(strip $(TARGET_FDO_CFLAGS)),)\n')
202 'ifneq ($(strip $($(LOCAL_2ND_ARCH_VAR_PREFIX)TARGET_FDO_CFLAGS)),)\n')
203 f.write('\t# This should be the last -Oxxx specified in LOCAL_CFLAGS\n') 202 f.write('\t# This should be the last -Oxxx specified in LOCAL_CFLAGS\n')
204 f.write('\tLOCAL_CFLAGS += -O2\n') 203 f.write('\tLOCAL_CFLAGS += -O2\n')
205 f.write('endif\n\n') 204 f.write('endif\n\n')
206 205
207 f.write('LOCAL_ARM_MODE := thumb\n') 206 f.write('LOCAL_ARM_MODE := thumb\n')
208 207
209 # need a flag to tell the C side when we're on devices with large memory 208 # need a flag to tell the C side when we're on devices with large memory
210 # budgets (i.e. larger than the low-end devices that initially shipped) 209 # budgets (i.e. larger than the low-end devices that initially shipped)
211 # On arm, only define the flag if it has VFP. For all other architectures, 210 # On arm, only define the flag if it has VFP. For all other architectures,
212 # always define the flag. 211 # always define the flag.
(...skipping 18 matching lines...) Expand all
231 if data.condition: 230 if data.condition:
232 f.write('ifeq ($(%s), true)\n' % data.condition) 231 f.write('ifeq ($(%s), true)\n' % data.condition)
233 write_local_vars(f, data.vars_dict, True, data.name) 232 write_local_vars(f, data.vars_dict, True, data.name)
234 if data.condition: 233 if data.condition:
235 f.write('endif\n\n') 234 f.write('endif\n\n')
236 235
237 write_include_stlport(f) 236 write_include_stlport(f)
238 f.write('include $(BUILD_SHARED_LIBRARY)\n') 237 f.write('include $(BUILD_SHARED_LIBRARY)\n')
239 f.write(SKIA_TOOLS) 238 f.write(SKIA_TOOLS)
240 239
OLDNEW
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698