Issue 489223002: Add chrome, installer_util targets to GN build.

Issue 489223002: Add chrome, installer_util targets to GN build. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
scottmg

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, grt+watch_chromium.org, wfh+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add chrome, installer_util targets to GN build. The chrome target doesn't link yet so is currently a source set. This adds some installer util targets and some related targets, as well as fixes up some TODOs referencing completed targets. Fixes and enables the snapshot unit test. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290927

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -103 lines)			Patch
M	chrome/BUILD.gn	View		2 chunks	+93 lines, -0 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View		9 chunks	+26 lines, -27 lines	0 comments	Download
M	chrome/browser/extensions/BUILD.gn	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_installer.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_installer_util.gypi	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/BUILD.gn	View		5 chunks	+9 lines, -32 lines	0 comments	Download
A	chrome/installer/util/BUILD.gn	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	chrome/renderer/BUILD.gn	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
A	chrome/version.gni	View		1 chunk	+60 lines, -0 lines	1 comment	Download
M	printing/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/snapshot/BUILD.gn	View	1	2 chunks	+31 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

You're making quite the mess for Windows! LGTM https://codereview.chromium.org/489223002/diff/40001/chrome/version.gni File chrome/version.gni (right): https://codereview.chromium.org/489223002/diff/40001/chrome/version.gni#newcode54 chrome/version.gni:54: "-f", ...

6 years, 4 months ago (2014-08-20 21:38:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as 290927.

Expand Messages | Collapse Messages