Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: ui/snapshot/BUILD.gn

Issue 489223002: Add chrome, installer_util targets to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/version.gni ('K') | « printing/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/snapshot/BUILD.gn
diff --git a/ui/snapshot/BUILD.gn b/ui/snapshot/BUILD.gn
index 78a28237d0f6e79e7e6be2872cd5865cb81dd814..f3d3bcc26493954dfc63b345e64bf5b69e172fb8 100644
--- a/ui/snapshot/BUILD.gn
+++ b/ui/snapshot/BUILD.gn
@@ -42,7 +42,7 @@ component("snapshot") {
if (use_aura) {
deps += [
- #"//ui/aura", TODO(GYP)
+ "//ui/aura",
"//ui/compositor",
]
} else {
@@ -52,35 +52,36 @@ component("snapshot") {
}
}
-# TODO(GYP) enable this when all targets are converted and it links
-#test("snapshot_unittests") {
-# sources = [
-# "snapshot_aura_unittest.cc",
-# "snapshot_mac_unittest.mm",
-# "test/run_all_unittests.cc",
-# ]
-#
-# deps = [
-# "//base",
-# "//base/allocator",
-# "//base/test:test_support",
-# "//skia",
-# "//testing/gtest",
-# "//ui/base",
-# "//ui/gfx",
-# "//ui/gfx/geometry",
-# ]
-#
-# if (use_aura) {
-# deps += [
-# #"//ui/aura:test_support", TODO(GYP)
-# "//ui/compositor",
-# "//ui/compositor:test_support",
-# ]
-# } else {
-# sources -= [ "snapshot_aura_unittest.cc" ]
-# }
-#}
+test("snapshot_unittests") {
+ sources = [
+ "snapshot_aura_unittest.cc",
+ "snapshot_mac_unittest.mm",
+ "test/run_all_unittests.cc",
+ ]
+
+ deps = [
+ ":snapshot",
+ "//base",
+ "//base/allocator",
+ "//base/test:test_support",
+ "//skia",
+ "//testing/gtest",
+ "//ui/base",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ ]
+
+ if (use_aura) {
+ deps += [
+ "//ui/aura:test_support",
+ "//ui/compositor",
+ "//ui/compositor:test_support",
+ "//ui/wm",
+ ]
+ } else {
+ sources -= [ "snapshot_aura_unittest.cc" ]
+ }
+}
if (is_win) {
source_set("test_support") {
« chrome/version.gni ('K') | « printing/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698