Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/ui/cocoa/location_bar/page_action_decoration.h

Issue 489183005: Make a ShowExtensionActionPopup function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/page_action_decoration.h
diff --git a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.h b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.h
index 4e3b77e9ad1d11868f37f010c63e88f66ffa58d5..e5d860f5da07d1bb31ac00b266a00916dc67fded 100644
--- a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.h
+++ b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.h
@@ -61,12 +61,14 @@ class PageActionDecoration : public ImageDecoration,
virtual NSMenu* GetMenu() OVERRIDE;
virtual NSPoint GetBubblePointInFrame(NSRect frame) OVERRIDE;
- // Activate the page action in its default frame.
- void ActivatePageAction();
+ // Activates the page action in its default frame, and, if |grant_active_tab|
+ // is true, grants active tab permission to the extension. Returns true if
+ // a popup was shown.
+ bool ActivatePageAction(bool grant_active_tab);
private:
// Activate the page action in the given |frame|.
- bool ActivatePageAction(NSRect frame);
+ bool ActivatePageAction(NSRect frame, bool grant_active_tab);
// Show the popup in the frame, with the given URL.
void ShowPopup(const NSRect& frame, const GURL& popup_url);

Powered by Google App Engine
This is Rietveld 408576698