Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3101)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 489183005: Make a ShowExtensionActionPopup function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 3e86f3632d830de34e02728f478d7528865ea38d..cd5cd4cb622f403533917365f13ab82d33cf12c5 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -233,6 +233,17 @@ void LocationBarViewMac::InvalidatePageActions() {
Layout();
}
+bool LocationBarViewMac::ShowPageActionPopup(
+ const extensions::Extension* extension, bool grant_active_tab) {
+ for (ScopedVector<PageActionDecoration>::iterator iter =
+ page_action_decorations_.begin();
+ iter != page_action_decorations_.end(); ++iter) {
+ if ((*iter)->page_action()->extension_id() == extension->id())
+ return (*iter)->ActivatePageAction(grant_active_tab);
+ }
+ return false;
+}
+
void LocationBarViewMac::UpdateOpenPDFInReaderPrompt() {
// Not implemented on Mac.
}
@@ -635,16 +646,6 @@ void LocationBarViewMac::ModelChanged(const SearchModel::State& old_state,
Layout();
}
-void LocationBarViewMac::ActivatePageAction(const std::string& extension_id) {
- for (size_t i = 0; i < page_action_decorations_.size(); ++i) {
- if (page_action_decorations_[i]->page_action()->extension_id() ==
- extension_id) {
- page_action_decorations_[i]->ActivatePageAction();
- return;
- }
- }
-}
-
void LocationBarViewMac::PostNotification(NSString* notification) {
[[NSNotificationCenter defaultCenter] postNotificationName:notification
object:[NSValue valueWithPointer:this]];

Powered by Google App Engine
This is Rietveld 408576698