Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: media/video/capture/win/video_capture_device_mf_win.cc

Issue 489183003: Log error messages in windows video capture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mcasas@s comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/win/video_capture_device_mf_win.cc
diff --git a/media/video/capture/win/video_capture_device_mf_win.cc b/media/video/capture/win/video_capture_device_mf_win.cc
index de1f6eb2dfff6056305637b94937a86eedae0b95..164f350bf35b9b94b7264ab096a4f0636e79a286 100644
--- a/media/video/capture/win/video_capture_device_mf_win.cc
+++ b/media/video/capture/win/video_capture_device_mf_win.cc
@@ -332,10 +332,10 @@ void VideoCaptureDeviceMFWin::OnIncomingCapturedData(
}
void VideoCaptureDeviceMFWin::OnError(HRESULT hr) {
- std::string log_msg = base::StringPrintf("VideoCaptureDeviceMFWin: %x", hr);
- DLOG(ERROR) << log_msg;
+ const std::string reason =
tommi (sloooow) - chröme 2014/08/28 08:48:46 move this variable into the scope below. (alternat
+ base::StringPrintf("VideoCaptureDeviceMFWin: %x", hr);
if (client_.get())
- client_->OnError(log_msg);
+ client_->OnError(reason);
}
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698