Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 489183003: Log error messages in windows video capture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mcasas@s comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_controller.cc
diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc
index 4fd53a88fb610b1262b25baee9e3761b6633fa56..83381252cd649ed179ee095121f7dcda4f39a186 100644
--- a/content/browser/renderer_host/media/video_capture_controller.cc
+++ b/content/browser/renderer_host/media/video_capture_controller.cc
@@ -516,8 +516,13 @@ VideoCaptureController::VideoCaptureDeviceClient::OnIncomingCapturedVideoFrame(
void VideoCaptureController::VideoCaptureDeviceClient::OnError(
const std::string& reason) {
- MediaStreamManager::SendMessageToNativeLog(
- "Error on video capture: " + reason);
+ const std::string last_error_message =
+ logging::SystemErrorCodeToString(logging::GetLastSystemErrorCode());
+ std::ostringstream log_message;
+ log_message << "Error on video capture: " << reason
+ << ", OS message: " << last_error_message;
tommi (sloooow) - chröme 2014/08/28 08:48:46 exchange last_error_message with the call to Syste
magjed_chromium 2014/08/28 14:50:39 Done.
+ DLOG(ERROR) << log_message.str();
tommi (sloooow) - chröme 2014/08/28 08:48:46 nit: no need to call .str() here
magjed_chromium 2014/08/28 14:50:39 Done.
+ MediaStreamManager::SendMessageToNativeLog(log_message.str());
BrowserThread::PostTask(BrowserThread::IO,
FROM_HERE,
base::Bind(&VideoCaptureController::DoErrorOnIOThread, controller_));

Powered by Google App Engine
This is Rietveld 408576698