Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489103002: Split up monolithic EXPERIMENTAL_drawPicture method (Closed)

Created:
6 years, 4 months ago by robertphillips
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Split up monolithic EXPERIMENTAL_drawPicture method This is prep for the new multi-picture API. This is split out of (Add new API to allow layer hoisting/atlasing across picture piles - https://codereview.chromium.org/474623002/) Committed: https://skia.googlesource.com/skia/+/64bf76722ef06eabf51b55afda9f4ff431e41460

Patch Set 1 #

Patch Set 2 : Fix indent #

Total comments: 2

Patch Set 3 : Addressed code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -51 lines) Patch
M include/gpu/SkGpuDevice.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 8 chunks +85 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 4 months ago (2014-08-20 15:47:32 UTC) #1
bsalomon
https://codereview.chromium.org/489103002/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/489103002/diff/20001/src/gpu/SkGpuDevice.cpp#newcode2068 src/gpu/SkGpuDevice.cpp:2068: void SkGpuDevice::drawLayers(const SkPicture* picture, why does this take non-const ...
6 years, 4 months ago (2014-08-21 14:14:01 UTC) #2
robertphillips
https://codereview.chromium.org/489103002/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/489103002/diff/20001/src/gpu/SkGpuDevice.cpp#newcode2068 src/gpu/SkGpuDevice.cpp:2068: void SkGpuDevice::drawLayers(const SkPicture* picture, On 2014/08/21 14:14:00, bsalomon wrote: ...
6 years, 4 months ago (2014-08-21 17:50:34 UTC) #3
bsalomon
lgtm
6 years, 4 months ago (2014-08-21 17:51:20 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 4 months ago (2014-08-21 17:51:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/489103002/40001
6 years, 4 months ago (2014-08-21 17:52:13 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:07:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 64bf76722ef06eabf51b55afda9f4ff431e41460

Powered by Google App Engine
This is Rietveld 408576698