Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 489093002: Enabling archiving of test results by default in run-webkit-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index d0a52bcebbf64c8ac3d56f715d78334047bfd5bf..2896ec7cfae5f27352fb623f75f06d4479f075a4 100644
--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -77,7 +77,7 @@ def main(argv, stdout, stderr):
bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug_rwt_logging)
bot_printer.print_results(run_details)
- if options.enable_versioned_results:
+ if options.archive_results:
gen_dash_board = GenerateDashBoard(port)
vivekg 2014/08/20 14:14:05 nit: GenerateDashBoard can be renamed to more clas
gen_dash_board.generate()
@@ -171,8 +171,9 @@ def parse_args(args):
help="Show all failures in results.html, rather than only regressions"),
optparse.make_option("--clobber-old-results", action="store_true",
default=False, help="Clobbers test results from previous runs."),
- optparse.make_option("--enable-versioned-results", action="store_true",
- default=False, help="Archive the test results for later access."),
+ optparse.make_option("--disable-results-archiving", dest='archive_results',
+ action="store_false", default=True,
+ help="Disable archiving of test results."),
Dirk Pranke 2014/08/20 16:15:19 Just get rid of the flag altogether, and make --cl
patro 2014/08/20 18:51:11 Done.
optparse.make_option("--smoke", action="store_true",
help="Run just the SmokeTests"),
optparse.make_option("--no-smoke", dest="smoke", action="store_false",
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/controllers/manager.py ('k') | Tools/Scripts/webkitpy/layout_tests/views/printing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698