Enabling archiving of test results by default in run-webkit-tests.

Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Szeged
 # Copyright (C) 2011 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 59 matching lines @@
         return test_run_results.UNEXPECTED_ERROR_EXIT_STATUS
 
     try:
         run_details = run(port, options, args, stderr)
         if ((run_details.exit_code not in test_run_results.ERROR_CODES or
              run_details.exit_code == test_run_results.EARLY_EXIT_STATUS) and
             not run_details.initial_results.keyboard_interrupted):
             bot_printer = buildbot_results.BuildBotPrinter(stdout, options.debug_rwt_logging)
             bot_printer.print_results(run_details)
 
-        if options.enable_versioned_results:
+        if options.archive_results:
             gen_dash_board = GenerateDashBoard(port)

[vivekg, 2014/08/20 14:14:05]

nit: GenerateDashBoard can be renamed to more class sounding name as:
DashBoardGenerator

             gen_dash_board.generate()
 
         return run_details.exit_code
 
     # We need to still handle KeyboardInterrupt, atleast for webkitpy unittest cases.
     except KeyboardInterrupt:
         return test_run_results.INTERRUPTED_EXIT_STATUS
     except test_run_results.TestRunException as e:
         print >> stderr, e.msg
         return e.code
@@ skipping 72 matching lines @@
             help="Use the specified port's baselines first"),
         optparse.make_option("--no-show-results", action="store_false",
             default=True, dest="show_results",
             help="Don't launch a browser with results after the tests "
                  "are done"),
         optparse.make_option("--full-results-html", action="store_true",
             default=False,
             help="Show all failures in results.html, rather than only regressions"),
         optparse.make_option("--clobber-old-results", action="store_true",
             default=False, help="Clobbers test results from previous runs."),
-        optparse.make_option("--enable-versioned-results", action="store_true",
-            default=False, help="Archive the test results for later access."),
+        optparse.make_option("--disable-results-archiving", dest='archive_results',
+            action="store_false", default=True,
+            help="Disable archiving of test results."),

[Dirk Pranke, 2014/08/20 16:15:19]

Just get rid of the flag altogether, and make --clobber-old-results delete
everything (all runs). 

If we have that, then I see no need to be able to turn off archiving. The
difference between keeping 1 run's results around and 10 doesn't matter much.

We can always add it later if we need to.

(i.e., merge this w/ the clobber patch as Vivek suggests ...)

[patro, 2014/08/20 18:51:11]

Done.

         optparse.make_option("--smoke", action="store_true",
             help="Run just the SmokeTests"),
         optparse.make_option("--no-smoke", dest="smoke", action="store_false",
             help="Do not run just the SmokeTests"),
     ]))
 
     option_group_definitions.append(("Testing Options", [
         optparse.make_option("--build", dest="build",
             action="store_true", default=True,
             help="Check to ensure the build is up-to-date (default)."),
@@ skipping 195 matching lines @@
         printer.print_config(port.results_directory())
 
         run_details = manager.run(args)
         _log.debug("Testing completed, Exit status: %d" % run_details.exit_code)
         return run_details
     finally:
         printer.cleanup()
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv[1:], sys.stdout, sys.stderr))