Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: src/top.cc

Issue 4888002: [Isolates] Pass isolate to VMState constructor. (Closed)
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/stub-cache.cc ('k') | src/vm-state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/top.cc
diff --git a/src/top.cc b/src/top.cc
index f2f03c1681d832d87a29915f76e1c5b5623ac49f..39b19a0cd335ddcc0e15865a36c81710de980650 100644
--- a/src/top.cc
+++ b/src/top.cc
@@ -443,15 +443,15 @@ bool Isolate::MayNamedAccess(JSObject* receiver, Object* key,
if (!callback) return false;
- HandleScope scope;
- Handle<JSObject> receiver_handle(receiver);
- Handle<Object> key_handle(key);
- Handle<Object> data(AccessCheckInfo::cast(data_obj)->data());
+ HandleScope scope(this);
+ Handle<JSObject> receiver_handle(receiver, this);
Dmitry Titov 2010/11/12 17:26:44 Should this just use the HeapObject version?
+ Handle<Object> key_handle(key, this);
+ Handle<Object> data(AccessCheckInfo::cast(data_obj)->data(), this);
LOG(ApiNamedSecurityCheck(key));
bool result = false;
{
// Leaving JavaScript.
- VMState state(EXTERNAL);
+ VMState state(this, EXTERNAL);
result = callback(v8::Utils::ToLocal(receiver_handle),
v8::Utils::ToLocal(key_handle),
type,
@@ -486,14 +486,14 @@ bool Isolate::MayIndexedAccess(JSObject* receiver,
if (!callback) return false;
- HandleScope scope;
- Handle<JSObject> receiver_handle(receiver);
- Handle<Object> data(AccessCheckInfo::cast(data_obj)->data());
+ HandleScope scope(this);
+ Handle<JSObject> receiver_handle(receiver, this);
Dmitry Titov 2010/11/12 17:26:44 same here.
+ Handle<Object> data(AccessCheckInfo::cast(data_obj)->data(), this);
LOG(ApiIndexedSecurityCheck(index));
bool result = false;
{
// Leaving JavaScript.
- VMState state(EXTERNAL);
+ VMState state(this, EXTERNAL);
result = callback(v8::Utils::ToLocal(receiver_handle),
index,
type,
« no previous file with comments | « src/stub-cache.cc ('k') | src/vm-state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698