[Isolates] Pass isolate to VMState constructor.

src/top.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 425 matching lines @@
   Object* data_obj =
      constructor->shared()->get_api_func_data()->access_check_info();
   if (data_obj == heap_.undefined_value()) return false;
 
   Object* fun_obj = AccessCheckInfo::cast(data_obj)->named_callback();
   v8::NamedSecurityCallback callback =
       v8::ToCData<v8::NamedSecurityCallback>(fun_obj);
 
   if (!callback) return false;
 
-  HandleScope scope;
-  Handle<JSObject> receiver_handle(receiver);
-  Handle<Object> key_handle(key);
-  Handle<Object> data(AccessCheckInfo::cast(data_obj)->data());
+  HandleScope scope(this);
+  Handle<JSObject> receiver_handle(receiver, this);

[Dmitry Titov, 2010/11/12 17:26:44]

Should this just use the HeapObject version?

+  Handle<Object> key_handle(key, this);
+  Handle<Object> data(AccessCheckInfo::cast(data_obj)->data(), this);
   LOG(ApiNamedSecurityCheck(key));
   bool result = false;
   {
     // Leaving JavaScript.
-    VMState state(EXTERNAL);
+    VMState state(this, EXTERNAL);
     result = callback(v8::Utils::ToLocal(receiver_handle),
                       v8::Utils::ToLocal(key_handle),
                       type,
                       v8::Utils::ToLocal(data));
   }
   return result;
 }
 
 
 bool Isolate::MayIndexedAccess(JSObject* receiver,
@@ skipping 14 matching lines @@
   Object* data_obj =
       constructor->shared()->get_api_func_data()->access_check_info();
   if (data_obj == heap_.undefined_value()) return false;
 
   Object* fun_obj = AccessCheckInfo::cast(data_obj)->indexed_callback();
   v8::IndexedSecurityCallback callback =
       v8::ToCData<v8::IndexedSecurityCallback>(fun_obj);
 
   if (!callback) return false;
 
-  HandleScope scope;
-  Handle<JSObject> receiver_handle(receiver);
-  Handle<Object> data(AccessCheckInfo::cast(data_obj)->data());
+  HandleScope scope(this);
+  Handle<JSObject> receiver_handle(receiver, this);

[Dmitry Titov, 2010/11/12 17:26:44]

same here.

+  Handle<Object> data(AccessCheckInfo::cast(data_obj)->data(), this);
   LOG(ApiIndexedSecurityCheck(index));
   bool result = false;
   {
     // Leaving JavaScript.
-    VMState state(EXTERNAL);
+    VMState state(this, EXTERNAL);
     result = callback(v8::Utils::ToLocal(receiver_handle),
                       index,
                       type,
                       v8::Utils::ToLocal(data));
   }
   return result;
 }
 
 
 const char* const Isolate::kStackOverflowMessage =
@@ skipping 410 matching lines @@
   Isolate::Current()->break_access()->Lock();
 }
 
 
 ExecutionAccess::~ExecutionAccess() {
   Isolate::Current()->break_access()->Unlock();
 }
 
 
 } }  // namespace v8::internal