Issue 4888002: [Isolates] Pass isolate to VMState constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4888002: [Isolates] Pass isolate to VMState constructor. (Closed)

Created:
10 years, 1 month ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
v8-dev

Visibility:
Public.

Description

[Isolates] Pass isolate to VMState constructor. Other functions in the class still do the TLS access, but they are only used by the profiler. So we'll clean them up once we get to the profiler.

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -71 lines)			Patch
M	src/api.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/builtins.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	src/cpu-profiler.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/execution.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/global-handles.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/global-handles.cc	View	6 chunks	+10 lines, -8 lines	0 comments	Download
M	src/handles.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	14 chunks	+14 lines, -14 lines	0 comments	Download
M	src/stub-cache.cc	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	src/top.cc	View	2 chunks	+9 lines, -9 lines	2 comments	Download
M	src/vm-state.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/vm-state-inl.h	View	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

10 years, 1 month ago (2010-11-12 17:26:44 UTC) #2

LGTM

Please consider the note below. I think it makes sense to always use a
HeapObject version of Handle ctor when possible (for consistency).

http://codereview.chromium.org/4888002/diff/1/src/top.cc
File src/top.cc (right):

http://codereview.chromium.org/4888002/diff/1/src/top.cc#newcode447
src/top.cc:447: Handle<JSObject> receiver_handle(receiver, this);
Should this just use the HeapObject version?

http://codereview.chromium.org/4888002/diff/1/src/top.cc#newcode490
src/top.cc:490: Handle<JSObject> receiver_handle(receiver, this);
same here.

Expand Messages | Collapse Messages