Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: build/util/lastchange.py

Issue 488733002: Get lastchange.py to work correctly on Git repositories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/util/lastchange.py
diff --git a/build/util/lastchange.py b/build/util/lastchange.py
index 8d758d2a24fdfa6daefada92491d739e055e5b7e..f910e9cdae727c79b82e6ede588ab7ab54c289d0 100755
--- a/build/util/lastchange.py
+++ b/build/util/lastchange.py
@@ -103,7 +103,7 @@ def FetchGitRevision(directory):
if proc:
output = proc.communicate()[0].strip()
if proc.returncode == 0 and output:
- return VersionInfo('git', output[:7])
+ return VersionInfo('git', output)
iannucci 2014/08/19 18:49:46 should we include the commit position here, if it'
agable 2014/08/19 22:00:30 The output cannot be multiline. It's unclear to me
return None
@@ -116,8 +116,7 @@ def FetchGitSVNURLAndRevision(directory, svn_url_regex):
Returns:
A tuple containing the Subversion URL and revision.
"""
- proc = RunGitCommand(directory, ['log', '-1',
- '--grep=git-svn-id', '--format=%b'])
+ proc = RunGitCommand(directory, ['log', '-1', '--format=%b'])
if proc:
output = proc.communicate()[0].strip()
if proc.returncode == 0 and output:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698