Get lastchange.py to work correctly on Git repositories.

build/util/lastchange.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 lastchange.py -- Chromium revision fetching utility.
 """
 
 import re
@@ skipping 85 matching lines @@
 
   Errors are swallowed.
 
   Returns:
     A VersionInfo object or None on error.
   """
   proc = RunGitCommand(directory, ['rev-parse', 'HEAD'])
   if proc:
     output = proc.communicate()[0].strip()
     if proc.returncode == 0 and output:
-      return VersionInfo('git', output[:7])
+      return VersionInfo('git', output)

[iannucci, 2014/08/19 18:49:46]

should we include the commit position here, if it's available in the commit
message?

[agable, 2014/08/19 22:00:30]

The output cannot be multiline. It's unclear to me what would happen if the
output had spaces in it, but given that it is going into a .h header file, I'm
not sure I want to risk it.

   return None
 
 
 def FetchGitSVNURLAndRevision(directory, svn_url_regex):
   """
   Fetch the Subversion URL and revision through Git.
 
   Errors are swallowed.
 
   Returns:
     A tuple containing the Subversion URL and revision.
   """
-  proc = RunGitCommand(directory, ['log', '-1',
-                                   '--grep=git-svn-id', '--format=%b'])
+  proc = RunGitCommand(directory, ['log', '-1', '--format=%b'])
   if proc:
     output = proc.communicate()[0].strip()
     if proc.returncode == 0 and output:
       # Extract the latest SVN revision and the SVN URL.
       # The target line is the last "git-svn-id: ..." line like this:
       # git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85528 0039d316....
       match = _GIT_SVN_ID_REGEX.search(output)
       if match:
         revision = match.group(2)
         url_match = svn_url_regex.search(match.group(1))
@@ skipping 147 matching lines @@
       if header:
         WriteIfChanged(header,
                        GetHeaderContents(header, opts.version_macro,
                                          version_info.revision))
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())