Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: Source/core/html/HTMLCanvasElement.cpp

Issue 488433003: Remove unused enum declaration ContextWebkit3d from HTMLCanvasElement::getContext() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing! Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLCanvasElement.cpp
diff --git a/Source/core/html/HTMLCanvasElement.cpp b/Source/core/html/HTMLCanvasElement.cpp
index e84eacf3bb509305325d62e996b246c48cc15f87..5a5af507606c2d06a78e8d6ce826761c6f100645 100644
--- a/Source/core/html/HTMLCanvasElement.cpp
+++ b/Source/core/html/HTMLCanvasElement.cpp
@@ -153,8 +153,8 @@ CanvasRenderingContext* HTMLCanvasElement::getContext(const String& type, Canvas
// context with any other type string will destroy any existing context.
enum ContextType {
Context2d,
- ContextWebkit3d,
- ContextExperimentalWebgl,
+ // Retain the enum values 'as is' as these are used by the histograms.
+ ContextExperimentalWebgl = 2,
rune 2014/08/22 12:15:50 I think it would be safer to explicitly assign a v
rune 2014/08/22 12:15:50 I think it would be safer to explicitly assign a v
ContextWebgl,
// Only add new items to the end and keep the order of existing items.
rune 2014/08/22 12:15:50 The comment in UseCounter for Feature looks cleare
ContextTypeCount,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698