Implement the host side of serial connection I/O on data pipe.

Implement the host side of serial connection I/O on data pipe.

This change adds DataSource and DataSink interface request parameters to
SerialService::Connect, passes them through to SerialConnection
instances via SerialConnectionFactory; the SerialConnection now uses a
DataSourceSender and a DataSinkReceiver for implementing serial receive
and send, respectively.

BUG=389016
Committed: https://crrev.com/d96dc3e6fe8023ee49e9facbc42cc600ee127a34
Cr-Commit-Position: refs/heads/master@{#292104}

[raymes, 2014-08-22 04:57:43]

Could you elaborate the CL description? It seems like there are some other
changes which are included in this CL.

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial.mojom
File device/serial/serial.mojom (right):

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial.moj...
device/serial/serial.mojom:95: DataSource& source);
Perhaps a comment for what sink and source are for?

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
File device/serial/serial_connection.cc (right):

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
device/serial/serial_connection.cc:30: base::Bind(base::DoNothing)),
Do we really not care about the error callbacks here?

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
File device/serial/serial_connection_unittest.cc (right):

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
device/serial/serial_connection_unittest.cc:301: io_handler_->set_send_callback(
Maybe add a comment to this function in TestIoHandler just making a note of when
this callback gets called.

https://codereview.chromium.org/488363002/diff/40001/extensions/renderer/reso...
File extensions/renderer/resources/serial_service.js (right):

https://codereview.chromium.org/488363002/diff/40001/extensions/renderer/reso...
extensions/renderer/resources/serial_service.js:132:
core.close(sendPipe.handle1);
Make a note that you will be implementing this in the future.

[Sam McNally, 2014-08-22 08:12:12]

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial.mojom
File device/serial/serial.mojom (right):

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial.moj...
device/serial/serial.mojom:95: DataSource& source);
On 2014/08/22 04:57:43, raymes wrote:
> Perhaps a comment for what sink and source are for?

Done.

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
File device/serial/serial_connection.cc (right):

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
device/serial/serial_connection.cc:30: base::Bind(base::DoNothing)),
On 2014/08/22 04:57:43, raymes wrote:
> Do we really not care about the error callbacks here? 

I don't think there's anything meaningful for the SerialConnection to do.

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
File device/serial/serial_connection_unittest.cc (right):

https://codereview.chromium.org/488363002/diff/40001/device/serial/serial_con...
device/serial/serial_connection_unittest.cc:301: io_handler_->set_send_callback(
On 2014/08/22 04:57:43, raymes wrote:
> Maybe add a comment to this function in TestIoHandler just making a note of
when
> this callback gets called.

Done.

https://codereview.chromium.org/488363002/diff/40001/extensions/renderer/reso...
File extensions/renderer/resources/serial_service.js (right):

https://codereview.chromium.org/488363002/diff/40001/extensions/renderer/reso...
extensions/renderer/resources/serial_service.js:132:
core.close(sendPipe.handle1);
On 2014/08/22 04:57:43, raymes wrote:
> Make a note that you will be implementing this in the future.

Done.

[raymes, 2014-08-25 02:33:30]

lgtm

[Sam McNally, 2014-08-26 00:30:13]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[Sam McNally, 2014-08-26 00:30:13]

+rockot

[Ken Rockot(use gerrit already), 2014-08-27 03:19:45]

lgtm

[Sam McNally, 2014-08-27 03:50:41]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-08-27 03:51:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/488363002/80001

[Sam McNally, 2014-08-27 03:51:46]

The CQ bit was unchecked by sammc@chromium.org

[Sam McNally, 2014-08-27 04:01:49]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-08-27 04:03:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/488363002/100001

[Sam McNally, 2014-08-27 04:16:21]

The CQ bit was unchecked by sammc@chromium.org

[Sam McNally, 2014-08-27 04:19:00]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-08-27 04:20:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/488363002/120001

[Sam McNally, 2014-08-27 04:49:45]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-08-27 04:50:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/488363002/140001

[commit-bot: I haz the power, 2014-08-27 06:41:48]

Committed patchset #6 (140001) as 3d5735a917c9a31dd015ca4524c6c4b302842867

[commit-bot: I haz the power, 2014-09-10 02:49:57]

Patchset 6 (id:??) landed as
https://crrev.com/d96dc3e6fe8023ee49e9facbc42cc600ee127a34
Cr-Commit-Position: refs/heads/master@{#292104}