Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: device/serial/serial_service_impl.cc

Issue 488363002: Implement the host side of serial connection I/O on data pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win x64 build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/serial_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_service_impl.cc
diff --git a/device/serial/serial_service_impl.cc b/device/serial/serial_service_impl.cc
index 093096d4c2cac15269f7a1262f332d41874e05c8..0f87695eedf5fff70e60c068085c9736e9a8b93d 100644
--- a/device/serial/serial_service_impl.cc
+++ b/device/serial/serial_service_impl.cc
@@ -55,11 +55,16 @@ void SerialServiceImpl::GetDevices(
void SerialServiceImpl::Connect(
const mojo::String& path,
serial::ConnectionOptionsPtr options,
- mojo::InterfaceRequest<serial::Connection> connection_request) {
+ mojo::InterfaceRequest<serial::Connection> connection_request,
+ mojo::InterfaceRequest<serial::DataSink> sink,
+ mojo::InterfaceRequest<serial::DataSource> source) {
if (!IsValidPath(path))
return;
- connection_factory_->CreateConnection(
- path, options.Pass(), connection_request.Pass());
+ connection_factory_->CreateConnection(path,
+ options.Pass(),
+ connection_request.Pass(),
+ sink.Pass(),
+ source.Pass());
}
SerialDeviceEnumerator* SerialServiceImpl::GetDeviceEnumerator() {
@@ -78,10 +83,4 @@ bool SerialServiceImpl::IsValidPath(const mojo::String& path) {
return false;
}
-void SerialServiceImpl::OnConnected(
- const mojo::Callback<void(serial::ConnectionInfoPtr)>& callback,
- serial::ConnectionInfoPtr result) {
- callback.Run(result.Pass());
-}
-
} // namespace device
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/serial_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698