chrome/browser/resources/extensions/extension_options_overlay.html - Issue 488293003: Embedded Extension Options: Improve the overlay popup UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.html

Issue 488293003: Embedded Extension Options: Improve the overlay popup UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extension_options_overlay.css ('K') | « chrome/browser/resources/extensions/extension_options_overlay.css ('k') | chrome/browser/resources/extensions/extension_options_overlay.js » ('j') | chrome/browser/resources/extensions/extension_options_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_options_overlay.html

diff --git a/chrome/browser/resources/extensions/extension_options_overlay.html b/chrome/browser/resources/extensions/extension_options_overlay.html

index 13ab347652f064bd4e38342a53241816763341f8..724c07a3cf73a2c8473635076cd0f150c1605d8e 100644

--- a/chrome/browser/resources/extensions/extension_options_overlay.html

+++ b/chrome/browser/resources/extensions/extension_options_overlay.html

@@ -5,6 +5,9 @@ in the LICENSE file.

-->

not at google - send to devlin 2014/08/22 22:31:00 The close button is on the right side of the box,

ericzeng 2014/08/23 00:14:49 The close button seems to find the right spot in t

- <h1 id="extension-options-overlay-title"></h1>

+ <div id="extension-options-overlay-header">

+ <div id="extension-options-overlay-icon"></div>

+ <h1 id="extension-options-overlay-title"></h1>

+ </div>

</div>