chrome/browser/resources/extensions/extension_options_overlay.html - Issue 488293003: Embedded Extension Options: Improve the overlay popup UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_options_overlay.html

Issue 488293003: Embedded Extension Options: Improve the overlay popup UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/extensions/extension_options_overlay.css ('K') | « chrome/browser/resources/extensions/extension_options_overlay.css ('k') | chrome/browser/resources/extensions/extension_options_overlay.js » ('j') | chrome/browser/resources/extensions/extension_options_overlay.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Copyright 2014 The Chromium Authors. All rights reserved.	2 Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be found	3 Use of this source code is governed by a BSD-style license that can be found

4 in the LICENSE file.	4 in the LICENSE file.

5 -->	5 -->

6 <div id="extension-options-overlay" class="page">	6 <div id="extension-options-overlay" class="page">

7 <div class="close-button"></div>	7 <div class="close-button"></div>
	not at google - send to devlin 2014/08/22 22:31:00 The close button is on the right side of the box, The close button is on the right side of the box, correct? It should be last in the DOM then. Perhaps that would solve some of the float/z-index issues. ericzeng 2014/08/23 00:14:49 The close button seems to find the right spot in t Show quoted text On 2014/08/22 22:31:00, kalman wrote: > The close button is on the right side of the box, correct? It should be last in > the DOM then. Perhaps that would solve some of the float/z-index issues. The close button seems to find the right spot in the overlay no matter where in the DOM I put it.
8 <h1 id="extension-options-overlay-title"></h1>	8 <div id="extension-options-overlay-header">

	9 <div id="extension-options-overlay-icon"></div>

	10 <h1 id="extension-options-overlay-title"></h1>

	11 </div>

9 <div id="extension-options-overlay-guest"></div>	12 <div id="extension-options-overlay-guest"></div>

10 </div>	13 </div>

OLD	NEW