chrome/test/data/password/done_and_separate_login_form.html - Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new …

Unified Diff: chrome/test/data/password/done_and_separate_login_form.html

Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@branch_autofill_todo_20140813

Patch Set: Incorporatd review comments and added unit-tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/separate_login_form.html » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/password/done_and_separate_login_form.html

diff --git a/chrome/test/data/password/done_and_separate_login_form.html b/chrome/test/data/password/done_and_separate_login_form.html

new file mode 100644

index 0000000000000000000000000000000000000000..67d20fc82c44616a925917d5b66314796f75dc19

--- /dev/null

+++ b/chrome/test/data/password/done_and_separate_login_form.html

@@ -0,0 +1,23 @@

+<html>

+<head>

+<script type="text/javascript">

+ window.onload = function() {

vabr (Chromium) 2014/08/26 09:42:58 nit: In short, use C++ indentation rules here: wi

Pritam Nikam 2014/08/26 12:41:33 Done.

+ document.getElementById('to_separate').action = getAction();

+ }

+ function getAction() {

vabr (Chromium) 2014/08/26 09:42:58 nit: The name is uninformative, it should express

Pritam Nikam 2014/08/26 12:41:33 Done.

+ var protocol = ("http:" == window.location.protocol) ? "https:" : "http:";

+ var actionUrl = protocol + "//" + window.location.host + "/password/done_and_separate_login_form.html";

vabr (Chromium) 2014/08/26 09:42:58 Why not use window.location.pathname, instead of r

vabr (Chromium) 2014/08/26 09:42:58 nit: This function is oblivious to the fact, that

Pritam Nikam 2014/08/26 12:41:33 Done.

+ return actionUrl;

+ }

+</script>

+</head>

+<body>

+Navigation complete. Below is the different login form pushed by server but with same action URL.

+The URL schem may or may not be same. Moreover, browser shall not promp user to save incorrect password.

+<form method="POST" id="to_separate">

+ <input type="text" id="username_separate" name="username_separate">

+ <input type="password" id="password_separate" name="password_separate">

+ <input type="submit" id="submit_separate" name="submit_separate">

+</form>

+</body>

+</html>