chrome/test/data/password/done_and_separate_login_form.html - Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new …

Side by Side Diff: chrome/test/data/password/done_and_separate_login_form.html

Issue 488083002: [Password Manager] Fix to recognise failed login attempt for sites where content server pushes new … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@branch_autofill_todo_20140813

Patch Set: Incorporatd review comments and added unit-tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/separate_login_form.html » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script type="text/javascript">

	4 window.onload = function() {
	vabr (Chromium) 2014/08/26 09:42:58 nit: In short, use C++ indentation rules here: wi nit: In short, use C++ indentation rules here: window.onload = function() { ...; } function foo() { var ...; ; } For more, have a look at http://dev.chromium.org/developers/web-development-style-guide#TOC-JavaScript, linked from http://dev.chromium.org/developers/coding-style. Pritam Nikam 2014/08/26 12:41:33 Done. Show quoted text On 2014/08/26 09:42:58, vabr (Chromium) wrote: > nit: In short, use C++ indentation rules here: > > window.onload = function() { > ...; > } > > function foo() { > var ...; > ; > } > > For more, have a look at > http://dev.chromium.org/developers/web-development-style-guide#TOC-JavaScript, > linked from http://dev.chromium.org/developers/coding-style. Done.
	5 document.getElementById('to_separate').action = getAction();

	6 }

	7 function getAction() {
	vabr (Chromium) 2014/08/26 09:42:58 nit: The name is uninformative, it should express nit: The name is uninformative, it should express that the returned URL is created from the current location by swapping the scheme between HTTP and HTTPS. For example: function getLocationWithHttpSchemeSecuritySwapped() {...} Pritam Nikam 2014/08/26 12:41:33 Done. Show quoted text On 2014/08/26 09:42:58, vabr (Chromium) wrote: > nit: The name is uninformative, it should express that the returned URL is > created from the current location by swapping the scheme between HTTP and HTTPS. > For example: > > function getLocationWithHttpSchemeSecuritySwapped() {...} Done.
	8 var protocol = ("http:" == window.location.protocol) ? "https:" : "http: ";

	9 var actionUrl = protocol + "//" + window.location.host + "/password/ done_and_separate_login_form.html";
	vabr (Chromium) 2014/08/26 09:42:58 Why not use window.location.pathname, instead of r Why not use window.location.pathname, instead of retyping the path again? vabr (Chromium) 2014/08/26 09:42:58 nit: This function is oblivious to the fact, that nit: This function is oblivious to the fact, that the resulting URL is assigned to the action attribute. So don't include "action" in the variable name, it's a bit confusing. Names like \|result\|, \|url\|, etc. would do fine. Pritam Nikam 2014/08/26 12:41:33 Done. Show quoted text On 2014/08/26 09:42:58, vabr (Chromium) wrote: > Why not use window.location.pathname, instead of retyping the path again? Done. Pritam Nikam 2014/08/26 12:41:33 Done. Show quoted text On 2014/08/26 09:42:58, vabr (Chromium) wrote: > nit: This function is oblivious to the fact, that the resulting URL is assigned > to the action attribute. So don't include "action" in the variable name, it's a > bit confusing. Names like \|result\|, \|url\|, etc. would do fine. Done.
	10 return actionUrl;

	11 }

	12 </script>

	13 </head>

	14 <body>

	15 Navigation complete. Below is the different login form pushed by server but with same action URL.

	16 The URL schem may or may not be same. Moreover, browser shall not promp user to save incorrect password.

	17 <form method="POST" id="to_separate">

	18 <input type="text" id="username_separate" name="username_separate">

	19 <input type="password" id="password_separate" name="password_separate">

	20 <input type="submit" id="submit_separate" name="submit_separate">

	21 </form>

	22 </body>

	23 </html>

OLD	NEW