Only show the checkbox for all urls when the switch is on

Only show the checkbox for all urls when the switch is on
BUG=402958
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290966

[Devlin, 2014-08-19 21:27:32]

gaaaah :(

[not at google - send to devlin, 2014-08-20 02:13:22]

lgtm.

I could put this regression down to a combined lack of attention to detail by
our subconscious awareness that this is all behind a flag.

But one day it won't be, and this would be an unfortunate bug to creep in.

I thought we had the ability to test the webui settings page somehow, the data
that gets passed in?

[Devlin, 2014-08-20 16:50:20]

On 2014/08/20 02:13:22, kalman wrote:
> lgtm.
> 
> I could put this regression down to a combined lack of attention to detail by
> our subconscious awareness that this is all behind a flag.
> 
> But one day it won't be, and this would be an unfortunate bug to creep in.
> 
> I thought we had the ability to test the webui settings page somehow, the data
> that gets passed in?

Huh.  I had no idea that we had tests for that.  Nifty.  Added one in for all
urls checkbox (fails before fix, works after).

[Devlin, 2014-08-20 16:50:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-08-20 16:51:23]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/487913004/...

[commit-bot: I haz the power, 2014-08-20 18:12:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44207)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 19:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 19:04:03]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Devlin, 2014-08-20 19:15:29]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-08-20 19:17:03]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/487913004/...

[commit-bot: I haz the power, 2014-08-20 20:08:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 22:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:10:37]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2014-08-20 22:11:05]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:12:18]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/487913004/...

[commit-bot: I haz the power, 2014-08-20 23:50:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 00:56:01]

Committed patchset #2 (20001) as 290966

[dewittj, 2014-08-21 03:44:43]

A revert of this CL (patchset #2) has been created in
https://codereview.chromium.org/491183002/ by dewittj@chromium.org.

The reason for reverting is: Conflicts with r290971.