chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 487913004: Only show the checkbox for all urls when the switch is on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 487913004: Only show the checkbox for all urls when the switch is on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add Test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index e99ae2ca046b13e1f546c74a0acda751afbe2a4b..7678bd6bd9f13e1916ad58b013ea8b23572b8a9e 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -291,7 +291,9 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(

// on those specified in the permissions.

bool wants_all_urls =

util::ScriptsMayRequireActionForExtension(extension) &&

- extension->permissions_data()->HasWithheldImpliedAllHosts();

+ (extension->permissions_data()->HasWithheldImpliedAllHosts() ||

+ util::AllowedScriptingOnAllUrls(

+ extension->id(), extension_service_->GetBrowserContext()));

extension_data->SetBoolean("wantsAllUrls", wants_all_urls);

extension_data->SetBoolean(

"allowAllUrls",

« no previous file with comments | « chrome/browser/extensions/extension_ui_unittest.cc ('k') | no next file » | no next file with comments »