Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: gm/rebaseline_server/static/live-view.html

Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add TODOs for Stephan Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/static/live-view.html
diff --git a/gm/rebaseline_server/static/live-view.html b/gm/rebaseline_server/static/live-view.html
index 44cbd0d337e1c250ad83dc5d3c8b40c0aa5ba044..6c158a6e7ec3d8b8a7c5c3373a3a70ec777b9f61 100644
--- a/gm/rebaseline_server/static/live-view.html
+++ b/gm/rebaseline_server/static/live-view.html
@@ -170,14 +170,11 @@
<!-- Submission UI that we only show in the Pending Approval tab. -->
<div ng-show="'Pending Approval' == viewingTab">
- <div style="font-size:20px">
- TODO(epoger): We don't yet support submitting new SKP expectations.
- </div>
<div style="display:inline-block">
<button style="font-size:20px"
ng-click="submitApprovals(filteredImagePairs)"
- ng-disabled="true || submitPending || (filteredImagePairs.length == 0)">
- Update these {{filteredImagePairs.length}} expectations on the server
+ ng-disabled="submitPending || (filteredImagePairs.length == 0)">
+ Get a patchfile to update these {{filteredImagePairs.length}} expectations
</button>
</div>
<div style="display:inline-block">
@@ -201,6 +198,12 @@
</li>
</ul>
</div>
+ <div ng-show="diffResults">
+ <p>
+ Here is the patch to apply to your local checkout:
+ <br>
+ <textarea rows="8" cols="50">{{diffResults}}</textarea>
+ </div>
</div>
<p>

Powered by Google App Engine
This is Rietveld 408576698