Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: gm/rebaseline_server/static/live-view.html

Issue 487853004: rebaseline_server: allow users to generate SKP diff patches on a shared instance (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add TODOs for Stephan Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <html ng-app="Loader" ng-controller="Loader.Controller"> 3 <html ng-app="Loader" ng-controller="Loader.Controller">
4 4
5 <head> 5 <head>
6 <title ng-bind="windowTitle"></title> 6 <title ng-bind="windowTitle"></title>
7 <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></scr ipt> 7 <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></scr ipt>
8 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.20/angular.js "></script> 8 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.20/angular.js "></script>
9 <script src="constants.js"></script> 9 <script src="constants.js"></script>
10 <script src="live-loader.js"></script> 10 <script src="live-loader.js"></script>
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 </button> 163 </button>
164 </td></tr> 164 </td></tr>
165 </tr></table></td> 165 </tr></table></td>
166 </tr> 166 </tr>
167 </table> 167 </table>
168 168
169 <p> 169 <p>
170 170
171 <!-- Submission UI that we only show in the Pending Approval tab. --> 171 <!-- Submission UI that we only show in the Pending Approval tab. -->
172 <div ng-show="'Pending Approval' == viewingTab"> 172 <div ng-show="'Pending Approval' == viewingTab">
173 <div style="font-size:20px">
174 TODO(epoger): We don't yet support submitting new SKP expectations.
175 </div>
176 <div style="display:inline-block"> 173 <div style="display:inline-block">
177 <button style="font-size:20px" 174 <button style="font-size:20px"
178 ng-click="submitApprovals(filteredImagePairs)" 175 ng-click="submitApprovals(filteredImagePairs)"
179 ng-disabled="true || submitPending || (filteredImagePairs.leng th == 0)"> 176 ng-disabled="submitPending || (filteredImagePairs.length == 0) ">
180 Update these {{filteredImagePairs.length}} expectations on the serve r 177 Get a patchfile to update these {{filteredImagePairs.length}} expect ations
181 </button> 178 </button>
182 </div> 179 </div>
183 <div style="display:inline-block"> 180 <div style="display:inline-block">
184 <div style="font-size:20px" 181 <div style="font-size:20px"
185 ng-show="submitPending"> 182 ng-show="submitPending">
186 Submitting, please wait... 183 Submitting, please wait...
187 </div> 184 </div>
188 </div> 185 </div>
189 <div> 186 <div>
190 Advanced settings... 187 Advanced settings...
191 <input type="checkbox" ng-model="showSubmitAdvancedSettings"> 188 <input type="checkbox" ng-model="showSubmitAdvancedSettings">
192 show 189 show
193 <ul ng-show="showSubmitAdvancedSettings"> 190 <ul ng-show="showSubmitAdvancedSettings">
194 <li ng-repeat="setting in [constants.KEY__EXPECTATIONS__REVIEWED, co nstants.KEY__EXPECTATIONS__IGNOREFAILURE]"> 191 <li ng-repeat="setting in [constants.KEY__EXPECTATIONS__REVIEWED, co nstants.KEY__EXPECTATIONS__IGNOREFAILURE]">
195 {{setting}} 192 {{setting}}
196 <input type="checkbox" ng-model="submitAdvancedSettings[setting]"> 193 <input type="checkbox" ng-model="submitAdvancedSettings[setting]">
197 </li> 194 </li>
198 <li ng-repeat="setting in ['bug']"> 195 <li ng-repeat="setting in ['bug']">
199 {{setting}} 196 {{setting}}
200 <input type="text" ng-model="submitAdvancedSettings[setting]"> 197 <input type="text" ng-model="submitAdvancedSettings[setting]">
201 </li> 198 </li>
202 </ul> 199 </ul>
203 </div> 200 </div>
201 <div ng-show="diffResults">
202 <p>
203 Here is the patch to apply to your local checkout:
204 <br>
205 <textarea rows="8" cols="50">{{diffResults}}</textarea>
206 </div>
204 </div> 207 </div>
205 208
206 <p> 209 <p>
207 210
208 <table border="0"><tr><td> <!-- table holding results header + results table --> 211 <table border="0"><tr><td> <!-- table holding results header + results table -->
209 <table border="0" width="100%"> <!-- results header --> 212 <table border="0" width="100%"> <!-- results header -->
210 <tr> 213 <tr>
211 <td> 214 <td>
212 Found {{filteredImagePairs.length}} matches; 215 Found {{filteredImagePairs.length}} matches;
213 <span ng-show="filteredImagePairs.length > limitedImagePairs.length" > 216 <span ng-show="filteredImagePairs.length > limitedImagePairs.length" >
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 ng-click="toggleSomeImagePairs($index, imagePair[constants.KE Y__IMAGEPAIRS__ROWSPAN])"> 433 ng-click="toggleSomeImagePairs($index, imagePair[constants.KE Y__IMAGEPAIRS__ROWSPAN])">
431 </tr> 434 </tr>
432 </table> <!-- imagePairs --> 435 </table> <!-- imagePairs -->
433 </td></tr></table> <!-- table holding results header + imagePairs table --> 436 </td></tr></table> <!-- table holding results header + imagePairs table -->
434 437
435 </div><!-- main display area of selected tab --> 438 </div><!-- main display area of selected tab -->
436 </div><!-- everything: hide until readyToDisplay --> 439 </div><!-- everything: hide until readyToDisplay -->
437 440
438 </body> 441 </body>
439 </html> 442 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698